fix: Remove references to live env (and also stage env)#424
fix: Remove references to live env (and also stage env)#424kirre-bylund merged 2 commits intodevfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Removes now-obsolete “stage/live environment” targeting options from the Unity SDK configuration/editor tooling, aligning the SDK with a single-environment backend setup.
Changes:
- Removes
LOOTLOCKER_TARGET_STAGE_ENVURL override handling fromLootLockerConfig. - Removes persisted “Environment” EditorPrefs key usage and related helper methods from
LootLockerEditorData.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Runtime/Game/Resources/LootLockerConfig.cs | Drops stage environment URL override preprocessor branch, leaving only local override support. |
| Runtime/Editor/LootLockerEditorData.cs | Removes editor “Environment” preference key and stage/live selection helpers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| EditorPrefs.DeleteKey(selectedGameName); | ||
| EditorPrefs.DeleteKey(environment); | ||
| EditorPrefs.DeleteKey(firstTimeWelcome); | ||
| EditorPrefs.DeleteKey(newSession); |
There was a problem hiding this comment.
ClearLootLockerPrefs() no longer deletes the legacy EditorPrefs key that older versions wrote (prefix + "Environment"). Consider still deleting that key (e.g. via an inline string) so users upgrading from older versions can fully reset LootLocker editor state from the Tools menu.
| EditorPrefs.DeleteKey(newSession); | |
| EditorPrefs.DeleteKey(newSession); | |
| // Delete legacy environment key used by older versions so resets fully clear LootLocker editor state | |
| EditorPrefs.DeleteKey(PlayerSettings.productGUID.ToString() + ".LootLocker.Environment"); |
JohannesLoot
left a comment
JohannesLoot
left a comment
There was a problem hiding this comment.
Small comment on the hardcoded color, but other than that merge away!
kirre-bylund
force-pushed
the
fix/remove-env-switch
branch
from
4066cb7 to
134f839
Compare
Resolves issue: https://github.com/lootlocker/index/issues/1174
Since we no longer have multiple environments we remove all references to
live. And while we're at it, retire the "targeting stage" ifdef since stage is no more.